lgoldstein commented on PR #446: URL: https://github.com/apache/mina-sshd/pull/446#issuecomment-1871737314
> There is completely unrelated stuff in this change. These things must not be in this change at all. Let's agree to disagree on this. My philosophy is that if, while changing a piece of code, one sees another piece of code that can be improved it can be considered. I agree with you that the extra change should not be too big as to shadow the original goal and introduce too much "noise". How big is "too big" ? How much is "too much" ? that's a judgment call. I believe that the unrelated changes introduced in this PR do not pose the risk of drowning the original intention. Obviously, you disagree - and that's fine too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
