[ 
https://issues.apache.org/jira/browse/TRINIDAD-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12720772#action_12720772
 ] 

Yee-Wah Lee commented on TRINIDAD-1512:
---------------------------------------

This is related to the code in 
trinidadinternal.convert.DateTimeConverter#getFormattingTimeZone().  In that 
method, it copies the converter's timezone and gives the clone a  custom ID:
    // set the id as "GMT Sign Hours : Minutes"
    StringBuilder zoneId = new StringBuilder(9);
    int rawOffset = zone.getRawOffset();
..
    int minutes = (rawOffset % _MILLIS_PER_HOUR) / _MILLIS_PER_MINUTE;
    if (minutes < 10)
    {
      zoneId.append('0');
    }
    zoneId.append(minutes);
    zone.setID(zoneId.toString());

This sets the ID as "GMT+rawOffset" (raw offset is independent of dst) for the 
timezone "America/New_York", which is -5h. 

Subsequently, when formatting the string, the underlying DateFormat calls 
TimeZone.getDisplayName() which checks if a custom ID is specified and returns 
that string.
        String id = getID();
        String[] names = getDisplayNames(id, locale);
        if (names == null) {
            if (id.startsWith("GMT")) {
                char sign = id.charAt(3);
                if (sign == '+' || sign == '-') {
                    return id;
                }
            }


> ConvertDateTime uses static GMT+x string for timezone display, doesn't update 
> for daylight savings
> --------------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-1512
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1512
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Components
>    Affects Versions:  1.2.11-core
>            Reporter: Yee-Wah Lee
>            Priority: Minor
>
> 1. Create a jsp that uses tr:convertDateTime to display timezone, e.g. 
>         <af:outputText value="#{demoInput.date}">
>         <af:convertDateTime type="both" timeStyle="full" 
> timeZone="America/New_York"/>
>         </af:outputText>
> where demoInput.date returns the current date, e.g. June 17 09, 1:00 PM
> 2. Run the jsp. For June 17 09 the timezone is actually EDT (GMT - 4). 
> Instead it displays as EST
>     6/17/2009 1:00:00 PM GMT-05:00
> If using the JSF standard DateTimeConverter, the output is:
>    Jun 17, 2009 1:00:00 PM EDT

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to