2010/12/6 David Jencks <[email protected]> > > On Dec 5, 2010, at 7:44 PM, Ivan wrote: > > > I am wondering whether the myfaces bundle could also export the spi.impl > package, I hope to take advantage of some codes there, e.g. > DefaultFacesConfigurationProvider, it contains some sort algorithm. > > thanks. > > > > I'd say if you need to expose the default implementation of the spi then > there is something wrong with the interface design. If the sorting is > universal then perhaps it should not be in a class implemented by a service > provider? >
Yes, in Geronimo, we have a sepearted algorthim for sorting. Currently, I still use the implementation from MyFaces to do it, maybe in the future I could move them to Geronimo side or it will be abstracted from current default spi provider. I also need to provide a mock external context to make it work. or I might need to copy some codes from myfaces. Another thing is that, I use the digester xml parser from MyFaces to parse all the faces configuration files, while we using jaxb tree in the past. This could be avoid, just did not want to add some codes to convert two FacesConfig objects. Thanks. > thanks > david jencks > > > > > -- > > Ivan > > -- Ivan
