Thanks Justin. Appreciate your feedback. > You may want to also double check the version of bootstrap you have bundled, the comment says 3.2 and that it is Apache licensed, however > github shows 3.2 is MIT licensed. [1] I think the change from Apache to MIT happened at around 3.0.3. [2] If this is the case can you add bootstrap > to the LICENSE file in the next release. However it may be that Twitter didn’t update the header of this file. If that's the case I’d just leave it as it is.
The bootstrap css bundled with Myriad was generated using http://bootswatchr.com/ by selecting version "3.2" of bootstrap. I suspect bootswatchr is not including the right license header. /*! * Bootstrap v3.2 * * Copyright 2014 Twitter, Inc * Licensed under the Apache License v2.0 * http://www.apache.org/licenses/LICENSE-2.0 * * Designed and built with all the love in the world by @mdo and @fat. * BootSwatchr built and provided by @DrewStrickland */ /*! normalize.css v3.0.1 | MIT License | git.io/normalize */ Created https://issues.apache.org/jira/browse/MYRIAD-177 to fix this for the next release. Thanks, Santosh On Mon, Nov 30, 2015 at 5:47 PM, Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > +1 binding. > > I checked: > - release name contains incubating > - signature and hash good > - DISCLAIMER exists > - LICENSE and NOTICE good. May be minor LICENSE issue re bootstrap (see > below). > - no unexpected binary files > - all source files have Apache headers > - can compile from source > > You might want to in the next release sign the release with an apache > email address. > > You may want to also double check the version of bootstrap you have > bundled, the comment says 3.2 and that it is Apache licensed, however > github shows 3.2 is MIT licensed. [1] I think the change from Apache to MIT > happened at around 3.0.3. [2] If this is the case can you add bootstrap to > the LICENSE file in the next release. However it may be that Twitter didn’t > update the header of this file. If that's the case I’d just leave it as it > is. Sorry I missed this last time. > > I also had to increase the memory in gradle.properties to get the project > to compile without an out of heap space error but that may just be my setup. > > Thanks, > Justin > > 1. https://github.com/twbs/bootstrap/tree/v3.2.0 < > https://github.com/twbs/bootstrap/tree/v3.2.0> > 2. https://github.com/twbs/bootstrap/tree/v3.0.3 < > https://github.com/twbs/bootstrap/tree/v3.0.3> > >
