Re: svn commit: r766236 - in /ofbiz/trunk/applications/marketing: script/org/ofbiz/sfa/lead/LeadServices.xml servicedef/services.xml

[Vikas Mayur]

IMO, this is not required at all except the one change that is to make contactMechId optional (because of earlier changes done by Andrew r765412). The current service does support this. I have tested the service createLead several times on earlier revision and it is working fine for me. To create a lead we have two options create lead and quick add lead and both of these are working fine. With former postal address is required and with latter postal address is not required.

Please correct me if I am wrong.

Vikas

On Apr 18, 2009, at 11:46 AM, jone...@apache.org wrote:

Author: jonesde
Date: Sat Apr 18 06:16:38 2009
New Revision: 766236

URL: http://svn.apache.org/viewvc?rev=766236&view=rev
Log:


Modified:

   ofbiz/trunk/applications/marketing/servicedef/services.xml


URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml?rev=766236&r1=766235&r2=766236&view=diff

@@ -53,6 +53,36 @@

                </call-service>
            </if-not-empty>
+            <if-not-empty field="parameters.address1">

+                    <simple-map-processor name="postalAddress">
+                        <process field="address1">
+                            <copy/>
+                        </process>
+                        <process field="address2">
+                            <copy/>
+                        </process>
+                        <process field="city">
+                            <copy/>
+                        </process>
+                        <process field="stateProvinceGeoId">
+                            <copy/>
+                        </process>
+                        <process field="countryGeoId">
+                            <copy/>
+                        </process>
+                        <process field="postalCode">
+                            <copy/>
+                        </process>
+                    </simple-map-processor>
+                </call-map-processor>
+                <check-errors/>

+                </call-service>
+            </if-not-empty>
        </else>
        </if-compare>


Modified: ofbiz/trunk/applications/marketing/servicedef/services.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/servicedef/services.xml?rev=766236&r1=766235&r2=766236&view=diff

@@ -385,8 +385,7 @@
    </service>

    <!-- lead services -->
-    <service name="createLead" engine="simple"

        <description>Create a Lead Person or Group</description>

            <exclude field-name="partyId"/>
@@ -398,7 +397,7 @@
            <exclude field-name="contactMechId"/>
        </auto-attributes>
        <attribute name="partyId" type="String" mode="OUT"/>
-        <attribute name="contactMechId" type="String" mode="OUT" />

Applied patch from Ean Schuessler in OFBIZ-2310, also changed service def for createLead to not require contactMechId out as there was an error from that in testing ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ LeadServices.xml Modified: ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/ lead/LeadServices.xml = = = = = = = = ====================================================================== --- ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ LeadServices.xml (original) +++ ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/ LeadServices.xml Sat Apr 18 06:16:38 2009 <result-to-result result-name="contactMechId" service-result-name="contactMechId"/> + <call-map-processor in-map-name="parameters" out- map-name="postalAddressCtx"> + <set field="postalAddressCtx.partyId" from- field="partyId"/> + <set field="postalAddressCtx.contactMechPurposeTypeId" value="PRIMARY_LOCATION"/> + <call-service service- name="createPartyPostalAddress" in-map-name="postalAddressCtx"> + <result-to-field result-name="contactMechId" field="postalContactMechId"/> = = = = = = = = ====================================================================== --- ofbiz/trunk/applications/marketing/servicedef/services.xml (original) +++ ofbiz/trunk/applications/marketing/servicedef/services.xml Sat Apr 18 06:16:38 2009 - location="component://marketing/script/org/ofbiz/sfa/lead/ LeadServices.xml" invoke="createLead"> + <service name="createLead" engine="simple" location="component://marketing/script/org/ofbiz/sfa/lead/ LeadServices.xml" invoke="createLead"> <auto-attributes entity-name="Person" mode="IN" optional="true"> + <attribute name="contactMechId" type="String" mode="OUT" optional="true"/> <attribute name="emailAddress" type="String" mode="IN" optional="true"/> <attribute name="groupName" type="String" mode="IN" optional="true"/> <attribute name="title" type="String" mode="IN" optional="true"/>

smime.p7s
Description: S/MIME cryptographic signature