On 12/03/2012 01:34 AM, jler...@apache.org wrote: > Author: jleroux > Date: Mon Dec 3 07:34:29 2012 > New Revision: 1416366 > > URL: http://svn.apache.org/viewvc?rev=1416366&view=rev > Log: > A patch from Carsten Schinzer for "Typo in new party-entitymodel" > https://issues.apache.org/jira/browse/OFBIZ-5090 > > The entitymodel.xml for party contains a typo on agreement_facility_appl: it > refers to faciliyId instead of facilityId. > This needs urgent fixing as otherwise any DB build done with the wrong > definition will generate errors (as the reference is part of a constraint).
Yeah, my bad, I was the one who didn't double check before committing. However, a better thing would be to make the entityengine bitch and die when such a badly formed entitymodel is read. It should *not* just issue a warning in these cases. > Modified: > ofbiz/trunk/applications/party/entitydef/entitymodel.xml > > Modified: ofbiz/trunk/applications/party/entitydef/entitymodel.xml > URL: > http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/entitydef/entitymodel.xml?rev=1416366&r1=1416365&r2=1416366&view=diff > ============================================================================== > --- ofbiz/trunk/applications/party/entitydef/entitymodel.xml (original) > +++ ofbiz/trunk/applications/party/entitydef/entitymodel.xml Mon Dec 3 > 07:34:29 2012 > @@ -289,7 +289,7 @@ under the License. > <field name="facilityId" type="id-ne"></field> > <prim-key field="agreementId"/> > <prim-key field="agreementItemSeqId"/> > - <prim-key field="faciliyId"/> > + <prim-key field="facilityId"/> > <relation type="one-nofk" rel-entity-name="Agreement"> > <key-map field-name="agreementId"/> > </relation> > @@ -298,7 +298,7 @@ under the License. > <key-map field-name="agreementItemSeqId"/> > </relation> > <relation type="one" fk-name="AGRMNT_FACLT_PRD" > rel-entity-name="Facility"> > - <key-map field-name="faciliyId"/> > + <key-map field-name="facilityId"/> > </relation> > </entity> > <entity entity-name="AgreementRole" > >