[ 
https://issues.apache.org/jira/browse/OFBIZ-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514317#comment-14514317
 ] 

Adam Heath commented on OFBIZ-6217:
-----------------------------------

Don't use UtilGenerics.cast() on an external lib call, if there is an update 
for that external lib that adds generics support.  Upgrading that external lib 
to a new generics-capable version is outside the scope of this issue, so in 
that case, just ignore the warnings.

File a separate issue, asking to get that external lib upgraded.  Cross-link 
the 2 issues.  When the lib is upgraded, then proceed with fixing the 
warnings(if they exist).  But, in theory, the other new issue would hit upon 
changes to the generics markup, so would need to fix it there.

As for the deprecation warnings, I've fixed all simple ones, except for any 
non-macro widget rendering.  I've made a branch with all my changes.  Please 
see the OFBIZ_6275 issue that Jacques mentioned.

> fix warnings in trunk on java source code
> -----------------------------------------
>
>                 Key: OFBIZ-6217
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-6217
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Taher Alkhateeb
>            Assignee: Adrian Crum
>            Priority: Minor
>              Labels: java, warning
>             Fix For: Upcoming Branch
>
>         Attachments: OFBIZ-6217-patch-4.patch, remove_unused_imports.patch, 
> warnings_patch_2.patch, warnings_patch_2.patch
>
>
> Right now, we have 528 warnings on trunk out of which 238 are about raw types 
> and 118 never used imports. So we can already eliminate most of the warning 
> quite quickly.
> I will issue multiple patches to resolve most of these warnings. It might be 
> a bit of a challenge to eliminate the raw types because the generics are not 
> always deducable from the code especially when relying on external APIs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to