On Tue, Mar 26, 2013 at 10:32:58AM +0100, Jürgen Schmidt wrote: > >>> You are right, these extensions were bundled with the > >>> installation; IMO it was a non-sense from the beginning to > >>> develop these as extensions (at least the presentation > >>> minimizer and the presenter screen, that have no external > >>> dependencies). > > I don't want to discuss the reason for the design as extension here > because it coming from the past and personally think extensions are > good fro many things but not for everything. > > What I would have preferred is at least a short proposal mail in front > of the change that you plan to do that.
Mea culpa, it didn't ever cross my mind to do so, nor thought the change was controversial, I just opened the bug reports on March the 9th https://issues.apache.org/ooo/show_bug.cgi?id=121871 https://issues.apache.org/ooo/show_bug.cgi?id=121872 https://issues.apache.org/ooo/show_bug.cgi?id=121873 submitted the patch, and in the weekend committed the code (which I tested on two platforms for two weeks). I would expect that people/developers are subscribed to our issues mailing list, and read the bug reports (at least, I do so). If for every code commit you expect a mail (and possible -IMO- pointless discussion here on the mailing list with people that know nothing about code - what at the ends is just of waste of developer time reading the mails and answering), then it would be better to implement code review, like LO has done with gerrit. > >> In this special case I would like to know how the user can turn > >> of the presenter screen. Did you add a button or option for > >> this?. > > > > No, I guess the user can deactivate the UNO component (I'm > > kidding). How does the user deactivate it now? As bundled extension > > is not listed in the Extension Manager. The average user will have > > no idea that the Presenter Screen is installed as an extension. > > > >> The original idea was that activation/deactivation is done by > >> activating/installing or deactivating/uninstalling the > >> extension. That was somewhat undermined by product managers who > >> shipped the extension with OOo but hid the Presenter Console > >> extension from the extension manager. It was still possible to > >> uninstall the extension but not via the UI. > > > > I don't see a regression here, from the user perspective, in 3.4.1 > > the Presenter Screen cannot be deactivated. > > The missing option to disable the presenter screen is a valid point > from Andre. As I answered to Hagar, an option in the Options dialog, and the respective configuration registry entry is the best approach, and very doable. Note that I am not a "lunatic" who wants to have always the reason and the last word, nor a "drama queen" who will leave to LO because someone didn't like a commit of mine; on the contrary, if Andre does not like the approach, I'm fine with him reverting it :) But please, if doing so, then * fix the preregister extension/uno sync brokenness on Linux * and/or fix the original bug with the deadlock which ended on the extension being prereg. * and make sure that in time, for the release, the extensions are ready to be released, too * fixing the problem of the double space consumption by preregistered extensions would also be fine, thought it does not seem simple All of these problems are not present with my approach of integrating these two extensions (I guess this is the reason why it never crossed my mind that this change would be something polemic/arguable). Regards -- Ariel Constenla-Haile La Plata, Argentina
pgpV6gF_ONdyF.pgp
Description: PGP signature
