On Thu, Nov 01, 2012 at 04:53:45PM +0000, Kyle Mestery (kmestery) wrote: > On Nov 1, 2012, at 2:23 AM, Ben Pfaff <b...@nicira.com> wrote: > > ofproto has a concept of "hidden" OpenFlow tables. Currently these are > > used internally only for ofproto-dpif for a couple of unimportant > > purposes. However, hidden tables were not hidden well enough, because > > OFTest was able to spot ofproto-dpif's hidden table and, seeing that it > > had a couple of flows in it even after OFTest had tried to delete all > > flows, failed at least one test. > > > > This commit hides the tables better: > > > > - The number of tables reported in a feature reply no longer counts > > hidden tables. > > > > - Table stats replies omit hidden tables. > > > > This commit introduces the requirement that hidden tables, if any, be the > > highest-numbered tables. This is because it's not clear to me that > > OpenFlow intends to allow tables to be numbered noncontiguously. > > > > Found by openflow_protocol_messages.ModifyStateDelete in OFTest. > > > > Signed-off-by: Ben Pfaff <b...@nicira.com> > > > Looks good. > > Acked-by: Kyle Mestery <kmest...@cisco.com>
Thanks. I pushed this to master. _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
