On Win32, there's a couple of minor things with the
ModPerl-Registry tests.
- in ModPerl-Registry/t/TEST.PL, Win32 likes to have
the volume letter in a different place, as in the
following diff:
Index: ModPerl-Registry/t/TEST.PL
===================================================================
RCS file: /home/cvs/modperl-2.0/ModPerl-Registry/t/TEST.PL,v
retrieving revision 1.5
diff -u -r1.5 TEST.PL
--- ModPerl-Registry/t/TEST.PL 23 Jan 2003 04:29:59 -0000 1.5
+++ ModPerl-Registry/t/TEST.PL 8 Mar 2003 07:41:35 -0000
@@ -8,6 +8,7 @@
use lib map {("../$_", "../../$_")} qw(lib Apache-Test/lib);
use Apache::TestRunPerl ();
+use Apache::TestConfig ();
# sub-class Apache::TestRunPerl
package MyTest;
@@ -25,7 +26,9 @@
my ($volume, $dir, $file) = splitpath Cwd::cwd(), 1;
my @dir = grep {length} splitdir $dir;
$dir = catdir @dir[0..($#dir-2)]; # remove two last dir segments
- my $base = rootdir() . catpath $volume, $dir, $file;
+ my $base = Apache::TestConfig::WIN32 ?
+ catpath $volume, rootdir(), $dir, $file :
+ rootdir() . catpath $volume, $dir, $file;
$self->{conf_opts}->{maxclients} = 2;
I think you don't need the Apache::TestConfig::WIN32 condition. I've wrote this as a cross-platform but have never tested on systems with $volume set. So your fix will probably correct for any system as just:
- my $base = rootdir() . catpath $volume, $dir, $file; + my $base = catpath $volume, rootdir(), $dir, $file;
+1 to commit
===================================================================
- in the ModPerl-Registry/t/basic.t test, some tests are made which rely on the setting of the executable bit, which isn't available on Win32. The following diff:
Index: ModPerl-Registry/t/basic.t
===================================================================
RCS file: /home/cvs/modperl-2.0/ModPerl-Registry/t/basic.t,v
retrieving revision 1.10
diff -u -r1.10 basic.t
--- ModPerl-Registry/t/basic.t 8 Mar 2003 03:20:36 -0000 1.10
+++ ModPerl-Registry/t/basic.t 8 Mar 2003 07:42:08 -0000
@@ -28,6 +28,10 @@
# test non-executable bit
for my $alias (@aliases) {
+ if (Apache::TestConfig::WIN32) {
+ skip "non-executable bit test for Win32", 0;
+ next;
+ }
my $url = "/$alias/not_executable.pl";
ok t_cmp(
============================================================ skips these tests for Win32.
+1
There's also something with the closure.t test - in running 'nmake test', test 4 of closure.t fails, but running closure.t individually allows all tests to pass.
You mean closure.t:4 fails only when some other tests run before. Do you know which one in particular? t/SMOKE should help figure it out.
A somewhat similar issue arose with the same interpreter mod_perl test (which now passes consistently).
You mean the whole same interpreter thing is not working under win32? I remember you were mentioning this before as well. There are now several tests that use the same interp setup. We need it to make sure that we hit the same interpreter.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
