Geoffrey Young wrote:
I never noticed it before, but 'make test' runs mod_perl core tests and ModPerl::Registry tests, but not Apache::Test tests. I kinda think we should be running all available tests, especially for software we're installing alongside mod_perl (even though it's a little backwards, testing Apache::Test _after_ we've used it to run the other tests :)

Do you really think we need that? the two test suites that we are running are already testing the Apache::Test itself. In addition to having almost no tests in the Apache::Test suite. It seems to be just an unnecessary overhead, especially for threaded-mpm, which takes agest to start each new 'make test' and to finish it.


I'd be all for it if Apache::Test was including tests unique to it.

So -0 here.

Index: Makefile.PL
===================================================================
RCS file: /home/cvspublic/modperl-2.0/Makefile.PL,v
retrieving revision 1.99
diff -u -r1.99 Makefile.PL
--- Makefile.PL 27 Mar 2003 05:22:26 -0000      1.99
+++ Makefile.PL 3 Apr 2003 16:41:27 -0000
@@ -445,6 +445,7 @@
    $(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
    t/TEST -verbose=$(TEST_VERBOSE) $(TEST_FILES)
    cd ModPerl-Registry && $(MAKE) test
+    cd Apache-Test && $(MAKE) test

 test :: pure_all run_tests test_clean
 EOF


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]


--


__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to