Philippe M. Chiasson wrote:

(That said, at a glance, I'm not convinced this patch
is necessary.)


Well, have you tried to do :

make distcheck lately ?

it warns about the files not in MANIFEST. So what? We know that our distro is autogenerated, why running 'make distcheck'?


Since we override 'make dist', we probably should just override the 'make distcheck' target as well.

And without a proper MANIFEST/MANIFEST.SKIP combo, making
signatures with Module::Signature is a problem.

$> cpansign -s
[...]
==> MISMATCHED content between MANIFEST and the distribution! <==
==> Please correct your MANIFEST file and/or delete extra files. <==

That sounds like a bug in cpansign. Since there is no mismatch between MANIFEST and the distro. They perfectly match. Granted you still get a warning about the autogenerated files (WrapXS/ and others) not being in MANIFEST, but it's not a reason to declare a mismatch.


So, the main reason I am trying to generate those 2 files is so that we can eventually generate signed distributions with M::S easily.

Why the autogenerated MANIFEST.SKIP is not included in the distro then?


Besides it now contains absolutely every file which is not in MANIFEST. If included in the distro it may include information users shouldn't see. not talking about wasted space.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to