francisoliverlee commented on issue #552: Is 
DefaultMQPullConsumerImpl#checkConfig redundant judgment the 
defaultMQPullConsumer.getConsumerGroup()
URL: https://github.com/apache/rocketmq/issues/552#issuecomment-440358076
 
 
   it has a WHY
   
![image](https://user-images.githubusercontent.com/5908412/48790518-80cb0c00-ed2a-11e8-8a97-e096871aa50b.png)
   
   checkConfig() will check both producer group and consumer group, if one is 
null, the Exception message is different. user can know what group is null.
   
   check process:
   1. check if group is null or empty
   2. check is group is under the group-rule(if greater than max-length...)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to