zjykzk commented on a change in pull request #2: Make code be consistent with Golang Specfication URL: https://github.com/apache/rocketmq-client-go/pull/2#discussion_r235227084
########## File path: core/message.go ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package rocketmq + +//#cgo LDFLAGS: -L/usr/local/lib/ -lrocketmq +//#include "rocketmq/CMessage.h" +//#include "rocketmq/CMessageExt.h" +import "C" +import "fmt" + +type Message struct { + Topic string + Keys string + // improve: maybe []byte is better. + Body string +} + +func (msg *Message) String() string { + return fmt.Sprintf("[topic: %s, keys: %s, body: %s]", msg.Topic, msg.Keys, msg.Body) +} + +type MessageExt struct { + Message + MessageID string + Tags string + // improve: is there is a method convert c++ map to go variable? + cmsgExt *C.struct_CMessageExt Review comment: export the operations of map to the c, then calling the exported function using cgo ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
