----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21057/#review42278 -----------------------------------------------------------
Committed revision 1592741. Please close the review. - Ryan Baxter On May 6, 2014, 2:57 a.m., Jiaqing Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21057/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 2:57 a.m.) > > > Review request for shindig, Dan Dumont, Ryan Baxter, Rich Thompson, and > Stanton Sievers. > > > Bugs: SHINDIG-1975 > https://issues.apache.org/jira/browse/SHINDIG-1975 > > > Repository: shindig > > > Description > ------- > > ContentTypes.extractMimePart will throw NullPointerException if the passed > contentType parameter is null. > Since this method is public, it should contain a basic parameter check before > doing business logic. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/protocol/ContentTypes.java > 1062768 > > http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/protocol/ContentTypesTest.java > 944062 > > Diff: https://reviews.apache.org/r/21057/diff/ > > > Testing > ------- > > > Thanks, > > Jiaqing Guo > >
