> On June 18, 2014, 12:06 a.m., Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java, > > line 241 > > <https://reviews.apache.org/r/22363/diff/2/?file=610533#file610533line241> > > > > Why not combine these two if statements? It would simplify the code a > > bit.
Has fixed the comment from Ryan, merge two "if" statements into one. - Jiaqing ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22363/#review46020 ----------------------------------------------------------- On June 18, 2014, 3:16 a.m., Jiaqing Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22363/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 3:16 a.m.) > > > Review request for shindig, Dan Dumont, Ryan Baxter, Rich Thompson, and > Stanton Sievers. > > > Bugs: SHINDIG-1978 > https://issues.apache.org/jira/browse/SHINDIG-1978 > > > Repository: shindig > > > Description > ------- > > If gadget spec contains a "ModulePrefs" tag with "title" attribute like below: > <ModulePrefs title="this is title" description="Hello World Embedded > Experience gadget" height="400" width="500"> > Then expect the loaded gadget should contain proper "title" element like > below: > <html> > <head> > <title>this is title</title> > ...... > But the actual result is the load gadget doesn't contain "title" element. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java > 1436455 > > Diff: https://reviews.apache.org/r/22363/diff/ > > > Testing > ------- > > > Thanks, > > Jiaqing Guo > >
