Has anyone had a chance to look at this? Just getting a feel as to if everyone thinks this is an acceptable fix.
doug On Sep 15, 2014, at 3:19 PM, Doug Davies <davi...@oclc.org<mailto:davi...@oclc.org>> wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25650/ Review request for shindig and Ryan Baxter. By Doug Davies. Updated Sept. 15, 2014, 7:19 p.m. Changes fixed unit tests and made nocache undefined if never defined in render or request params Bugs: SHINDIG-1983<https://issues.apache.org/jira/browse/SHINDIG-1983> Repository: shindig Description The NO_CACHE RenderParam does not appear to affect makeRequest. This fix adds a NO_CACHE request param and if that's not defined then it tries to use the NO_CACHE render param and if that's not defined then no caching occurs. Testing I've tested the following scenarios renderParams[osapi.container.RenderParam.NO_CACHE] = true; (and false) and params[gadgets.io.RequestParameters.NO_CACHE] = 1; (and 0) and neither defined Diffs (updated) * trunk/features/src/main/javascript/features/core.io/io.js (1625072) * trunk/features/src/test/javascript/features/core.io/iotest.js (1515531) View Diff<https://reviews.apache.org/r/25650/diff/>
