----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34673/#review88072 -----------------------------------------------------------
Ship it! Ship It! - Ryan Baxter On June 16, 2015, 1:32 p.m., Doug Davies wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34673/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 1:32 p.m.) > > > Review request for shindig. > > > Bugs: SHINDIG-1995 > https://issues.apache.org/jira/browse/SHINDIG-1995 > > > Repository: shindig > > > Description > ------- > > GadgetSite setModuleId_ only sets the module id if rendering the first time > > > Diffs > ----- > > > trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js > 1681771 > trunk/features/src/test/javascript/features/container/gadget_site_test.js > 1681771 > > Diff: https://reviews.apache.org/r/34673/diff/ > > > Testing > ------- > > See bug (SHINDIG-1995) for details on how to test this. UPDATE: there is now > a testReNavigateToWithModuleId unit test in gadget_site_test.js. > > > Thanks, > > Doug Davies > >
