[ https://issues.apache.org/jira/browse/SLING-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701206#comment-17701206 ]
Stefan Egli commented on SLING-11805: ------------------------------------- * fix pushed * PR ready for review : https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/14 > Don't stop slingId cleanup upon PROPERTIES_CHANGED > -------------------------------------------------- > > Key: SLING-11805 > URL: https://issues.apache.org/jira/browse/SLING-11805 > Project: Sling > Issue Type: Improvement > Components: Discovery > Affects Versions: Discovery Oak 1.2.40 > Reporter: Stefan Egli > Assignee: Stefan Egli > Priority: Minor > Fix For: Discovery Oak 1.2.44 > > Time Spent: 10m > Remaining Estimate: 0h > > As a follow-up to SLING-10854 where the SlingIdCleanupTask was introduced. > The current implementation stops cleanup when it received a > PROPERTIES_CHANGED event. This is actually wrong. It should continue. The way > it is currently done has the effect that cleanup is only triggered upon a > TOPOLOGY_INIT or TOPOLOGY_CHANGED without a following PROPERTIES_CHANGED. > This current behaviour reduces the chances of the cleanup running - having > said that, the likelyhood of the cleanup eventually running is still very > high. -- This message was sent by Atlassian Jira (v8.20.10#820010)