[
https://issues.apache.org/jira/browse/SLING-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790081#comment-17790081
]
Rob McDougall edited comment on SLING-12131 at 11/27/23 1:24 PM:
-----------------------------------------------------------------
[PR Created|https://github.com/apache/sling-parent/pull/40]
Discretion being the better part of valour, I decided to leave the explicit
JUnit4 version in the pom.xml rather than rely on the transient JUnit5 Vintage
Engine.
I checked out a small number of sling projects, altered them to use the updated
parent pom and they compiled OK except for apache.sling.junit.teleporter which
experienced a bunch of maven enforcer plugin errors that are unrelated to the
junit change but rather connected to some new enforcer rules that have been
implemented since the last time the parent pom dependency was changed.
After that, as a test,, I took some of the projects that worked and switched
them over to jUnit Vintage engine and that seemed to work.
I'm thinking that any additional work to actually utilize the new dependency
will have to wait until version 60 of the sling-parent is actually released,
otherwise the PRs will contain references to the 60-SNAPSHOT version which is
additional work to merge.
If that's not the case, let me know and I can start work on moving some of the
projects from JUnit4 to JUnit5 sooner.
was (Author: rmcdouga):
PR Created
Discretion being the better part of valour, I decided to leave the explicit
JUnit4 version in the pom.xml rather than rely on the transient JUnit5 Vintage
Engine.
I checked out a small number of sling projects, altered them to use the updated
parent pom and they compiled OK except for apache.sling.junit.teleporter which
experienced a bunch of maven enforcer plugin errors that are unrelated to the
junit change but rather connected to some new enforcer rules that have been
implemented since the last time the parent pom dependency was changed.
After that, as a test,, I took some of the projects that worked and switched
them over to jUnit Vintage engine and that seemed to work.
I'm thinking that any additional work to actually utilize the new dependency
will have to wait until version 60 of the sling-parent is actually released,
otherwise the PRs will contain references to the 60-SNAPSHOT version which is
additional work to merge.
If that's not the case, let me know and I can start work on moving some of the
projects from JUnit4 to Junit5 sooner.
> Update sling-parent pom.xml to include JUnit5 dependencies
> ----------------------------------------------------------
>
> Key: SLING-12131
> URL: https://issues.apache.org/jira/browse/SLING-12131
> Project: Sling
> Issue Type: Task
> Reporter: Rob McDougall
> Priority: Major
>
> JUnit4 is in maintenance mode (no updates in the last 2 years and then only
> security fixes). I think updating projects to JUnit5 should be encouraged.
> I am thinking this should be a relatively easy change of adding the
> junit-jupiter and junit-vintage-engine into the Dependency Management section
> of the sling-parent.
> Once this is done, individual projects could switch to the vintage-engine (at
> the very least) or move to jupiter by switching the dependency in their
> project pom.
> Some day down the road, the JUnit 4 dependencies could be removed. Projects
> that have not updated to JUnit5 (vintage or jupiter) by that time are likely
> no longer maintained.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
