[ https://issues.apache.org/jira/browse/SLING-12278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831922#comment-17831922 ]
Konrad Windszus commented on SLING-12278: ----------------------------------------- [~sseifert] I would appreciate your input here as for me there is way too much magic inside https://github.com/apache/sling-org-apache-sling-testing-sling-mock/blob/41c4a554333a2fc8c32f9bd233290132b638de4b/junit5/src/main/java/org/apache/sling/testing/mock/sling/junit5/SlingContextExtension.java#L41-L62. > Improve handling of late initialized context in > SlingContextExtension/OsgiContextExtension > ------------------------------------------------------------------------------------------ > > Key: SLING-12278 > URL: https://issues.apache.org/jira/browse/SLING-12278 > Project: Sling > Issue Type: Improvement > Reporter: Konrad Windszus > Priority: Major > > Currently neither in > https://sling.apache.org/documentation/development/osgi-mock.html#junit-5-osgi-context-junit-extension > nor in > https://sling.apache.org/documentation/development/sling-mock.html#junit-5-sling-context-junit-extension > it is mentioned that the context must not be initialized in {{@BeforeAll}} > or {{@BeforeEach}} as at that point in time the extension has already > initialized another context. Those two context may lead to subtle issues (for > example if resources are only added in the second context). For a concrete > example look at https://github.com/wcm-io/io.wcm.testing.aem-mock/issues/37. > In the best case the JUnit5 extension never creates a context (but only uses > the existing instance) or at least creation should be deferred until the > Before methods have been executed. -- This message was sent by Atlassian Jira (v8.20.10#820010)