[ 
https://issues.apache.org/jira/browse/SLING-2976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718167#comment-13718167
 ] 

Felix Meschberger edited comment on SLING-2976 at 7/24/13 9:29 AM:
-------------------------------------------------------------------

I am tempted to reopen this issues:

I like the idea of these additional information items -- though I don't really 
understand what a name of an instance means: Is it a human consumable short 
string, while the description is the human consumable "long" string ?

Yet, I think the public and regular API must not have setter methods. These are 
not protected and any consumer can just change the values however they like.

It would prefer to have these values configurable through the Configuration 
Admin service -- thus probably having the SlingSettingsServiceImpl be a 
ManagedService (or maybe have an internal helper class being the ManagedService 
which is registered as a ServiceFactory for lazy CM API resolution).
                
      was (Author: fmeschbe):
    I am tempted to reopen this issues:

I think the public and regular API must not have setter methods. These are not 
protected and any consumer can just change the values however they like.

It would prefer to have these values configurable through the Configuration 
Admin service -- thus probably having the SlingSettingsServiceImpl be a 
ManagedService (or maybe have an internal helper class being the ManagedService 
which is registered as a ServiceFactory for lazy CM API resolution).
                  
> Add support for instance name and description
> ---------------------------------------------
>
>                 Key: SLING-2976
>                 URL: https://issues.apache.org/jira/browse/SLING-2976
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>    Affects Versions: Extensions Settings 1.2.2
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: Extensions Settings 1.2.4
>
>
> With the introduction of the topology API, we added support for two framework 
> properties sling.name and sling.description. Right now, these values need 
> either be set as system properties or in the sling.properties file.
> There are two issues with these:
> - we don't have any default values
> - they are not changeable at run time

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to