Can someone please summarize what exactly is proposed, especially for SLING-3388 ?
Thanks Carsten 2014-02-12 11:14 GMT+01:00 Felix Meschberger <fmesc...@adobe.com>: > > Am 12.02.2014 um 11:01 schrieb Chetan Mehrotra <chetan.mehro...@gmail.com > >: > > > For now I think we can keep the implementation simple. For example in > > current case we do not have to change start level for Fragments and > > Slf4j related bundle. So need to change start level of some listed > > bundles only > > > >> startlevel 20 40 > > Do not see a requirement to move all existing bundle to different level > > ok > > > > >> startlevel .* 2 > >> startlevel .*\.installer\..* 2 > > > > For now would like to keep it simple to > > > > changestartlevel <symbolic name:version?> <target level> > > I still would suggest to support a version range, though. > > > > > If need arises for more advance usecase then they can be added later > > > > Created SLING-3388 for the same. > > Thanks > Felix > > > Chetan Mehrotra > > > > > > On Wed, Feb 12, 2014 at 2:58 PM, Felix Meschberger <fmesc...@adobe.com> > wrote: > >> Hi > >> > >> Am 12.02.2014 um 09:58 schrieb Felix Meschberger <fmesc...@adobe.com>: > >> > >>> Hi > >>> > >>> Am 12.02.2014 um 09:22 schrieb Chetan Mehrotra < > chetan.mehro...@gmail.com>: > >>> > >>>> On Wed, Feb 12, 2014 at 1:26 PM, Felix Meschberger < > fmesc...@adobe.com> wrote: > >>>>> Hence, I would really prefer to get our start levels straight and > reserve 1 to logging and move the install stuff to 2. > >>>> > >>>> You never allow to take the short cut :) > >>> > >>> I fight special cases as long as possible, yes :-) > >>> > >>>> > >>>> Okie thinking about tackling the real problem of moving existing > >>>> bundle to start level > 1 I can think of following approach > >>>> > >>>> 1. Currently we are not using startlevel 2,3,4 > >>> > >>> Yes. > >>> > >>>> > >>>> 2. Introduce a new command ChangeStartLevelCommand which would use the > >>>> StartLevel service to change the start level of non fragment bundle > >>>> having existing level 1. or it can be generic to change the level from > >>>> a -> b. > >>>> > >>>> One thing to decide at this step is that command should work on > >>>> explicit parameters e.g. change start level only for list bundles > >>>> OR Is an automatic one where it would find all bundles at 1 and change > >>>> levels for non fragment and non logging related bundle > >>> > >>> You mean a command for bootstrap.txt like uninstall ? Sounds good. > >>> > >>> This command could take a regular expression for symbolic names and > optionally a version range to select bundles and then a target start level. > Optionally it could take a source start level and a target start level to > move all bundles with the source start level to the target start level > >> > >> EBND definition: > >> > >> StartLevelCommand = "startlevel" Source TargetStartLevel . > >> Source = SourceStartLevel > >> | Bundle . > >> SourceStartLevel = numeric startlevel value > 0 . > >> TargetStartLevel = numeric startlevel value > 0 . > >> Bundle = BundleSymbolicName VersionRange . > >> BundleSymbolicName = regular expression match for bundle symbolic name > . > >> VersionRange = OSGi version range to match bundles . > >> > >> Examples: > >> > >> # move all bundles currently set to startlevel 20 to startlevel 40 > >> startlevel 20 40 > >> > >> # move all bundles to startlevel 2 > >> startlevel .* 2 > >> > >> # move installer bundles to startlevel 2 > >> startlevel .*\.installer\..* 2 > >> > >> Regards > >> Felix > >> > >>> > >>> +1 > >>> > >>>> > >>>> 3. Change the list.xml and move non fragment bundle (except loggging > >>>> related) to level 2 > >>> > >>> +1 > >>> > >>>> > >>>> Would this work or is something missing here? > >>> > >>> Sounds good to me. > >>> > >>> Regards > >>> Felix > >>> > >>>> > >>>> Chetan Mehrotra > >>> > >> > > -- Carsten Ziegeler cziege...@apache.org
