[
https://issues.apache.org/jira/browse/SLING-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997947#comment-13997947
]
Justin Edelson commented on SLING-3499:
---------------------------------------
Hi [~kwin], sorry for the delay looking at this. I went through and did some
refactoring. Please reivew http://codereview.appspot.com/95250047
Here's a summary of the changes:ere's a summary of the changes:
1) Moved new SPI interfaces/classes into separate package
2) Renamed Value annotation to ValueMapValue
3) Changed ModelInject to InjectAnnotation (which is somewhat repetitive, but
since end users never use it, this seemed OK)
4) Made all the annotation processors inner classes.
5) Reduced the use of annonymous inner classes to avoid extra object creation.
6) Moved some things around inside injectFieldOrMethod() so that
createAnnotationProcessor was only called if the source matches.
> Support custom annotations with Sling Models
> --------------------------------------------
>
> Key: SLING-3499
> URL: https://issues.apache.org/jira/browse/SLING-3499
> Project: Sling
> Issue Type: New Feature
> Components: Extensions
> Affects Versions: Sling Models API 1.0.0, Sling Models Implementation 1.0.2
> Reporter: Konrad Windszus
>
> To support custom annotations the API needs to be extended.
> The reasons for custom annotations are listed in
> http://www.mail-archive.com/dev%40sling.apache.org/msg27918.html. Also it is
> much more comfortable for developers, since they can use code completion in
> the IDE to see which options are available for each injector-specific
> annotation, apart from that it is less code to write (instead of multiple
> annotations on one field/method I would only have to write one annotation
> with some attributes).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
