[ https://issues.apache.org/jira/browse/SLING-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216193#comment-14216193 ]
ASF GitHub Bot commented on SLING-4180: --------------------------------------- GitHub user raducotescu opened a pull request: https://github.com/apache/sling/pull/43 SLING-4180 - Sightly Engine should properly reimport its own API export * added ProviderType annotation for services implemented by the engine bundle * added ConsumerType annotation for services that can be implemented by other bundles You can merge this pull request into a Git repository by running: $ git pull https://github.com/raducotescu/sling issue/SLING-4180 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 ---- commit 69d36b1a35d0a42ebb83ea820afd1ed856914e68 Author: Radu Cotescu <r...@apache.org> Date: 2014-11-18T14:02:54Z SLING-4180 - Sightly Engine should properly reimport its own API export * added ProviderType annotation for services implemented by the engine bundle * added ConsumerType annotation for services that can be implemented by other bundles ---- > Sightly Engine should properly reimport its own API export > ---------------------------------------------------------- > > Key: SLING-4180 > URL: https://issues.apache.org/jira/browse/SLING-4180 > Project: Sling > Issue Type: Bug > Components: Scripting > Affects Versions: Scripting Sightly Engine 1.0.0 > Reporter: Radu Cotescu > Priority: Minor > Fix For: Scripting Sightly Engine 1.0.0 > > > The Sightly API needs to be cleaned up such that the import versions are > properly set by marking all interfaces as either {{@ConsumerType}} or > {{@ProviderType}}. > The package export should be defined with a {{package-info.java}} file > instead of in the {{pom.xml}} such that the export is close to the source. -- This message was sent by Atlassian JIRA (v6.3.4#6332)