[ 
https://issues.apache.org/jira/browse/SLING-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240974#comment-14240974
 ] 

Timothee Maret commented on SLING-4234:
---------------------------------------

The question is, should the Javadoc change to match what the implementation 
does (arguably, lots of code has already be written to support the null 
reference and thus, would not be broken) or align the implementation on the API 
(potentially breaking existing code).

> Tenant create implementation does not match with the API 
> ---------------------------------------------------------
>
>                 Key: SLING-4234
>                 URL: https://issues.apache.org/jira/browse/SLING-4234
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Tenant 1.0.2
>            Reporter: Timothee Maret
>             Fix For: Tenant 1.0.4
>
>
> The API org.apache.sling.tenant.TenantManager#create stipulates
> {code}
> @throws IllegalArgumentException if a tenant with the same {@code tentantId} 
> already exists.
> {code}
> However, the implementation in 
> org.apache.sling.tenant.internal.TenantProviderImpl#create does not implement 
> this. Instead, it returns null when the tenant already exists.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to