Indeed Eclipse supports configurable annotations. You can find the information at http://help.eclipse.org/juno/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Freference%2Fpreferences%2Fjava%2Fcompiler%2Fref-preferences-errors-warnings.htm&anchor=null_annotation_names <http://help.eclipse.org/juno/index.jsp?topic=/org.eclipse.jdt.doc.user/reference/preferences/java/compiler/ref-preferences-errors-warnings.htm&anchor=null_annotation_names>. Therefore it will probably make sense to use the JSR305 annotations. I will create a feature branch where I will add those annotations for Sling API as well as Sling Models and Sling Validation. Thanks for your input.
> On 30 Jan 2015, at 13:59, Robert Munteanu <[email protected]> wrote: > > On Fri, Jan 30, 2015 at 2:55 PM, Konrad Windszus <[email protected] > <mailto:[email protected]>> wrote: >> The question for me is whether we should rely on the dormant standard (which >> did never release anything officially) 305, because that is not supported by >> Eclipse or whether we should use something else? >> Any ideas, opinions on that? >> What is your experience with the JSR305 javax.annotation support in major >> IDEs (see also >> http://stackoverflow.com/questions/4963300/which-notnull-java-annotation-should-i-use >> >> <http://stackoverflow.com/questions/4963300/which-notnull-java-annotation-should-i-use> >> >> <http://stackoverflow.com/questions/4963300/which-notnull-java-annotation-should-i-use >> >> <http://stackoverflow.com/questions/4963300/which-notnull-java-annotation-should-i-use>>)? > > AFAIR for Eclipse you can configure the annotation types to use ( see > [1] ) . But of course we'd need to validate this before starting > conversions. > > Robert > > > [1]: > http://help.eclipse.org/luna/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Ftasks%2Ftask-using_null_annotations.htm > > <http://help.eclipse.org/luna/index.jsp?topic=%2Forg.eclipse.jdt.doc.user%2Ftasks%2Ftask-using_null_annotations.htm> > >> Konrad >> >>> On 30 Jan 2015, at 13:37, Robert Munteanu <[email protected]> wrote: >>> >>> On Fri, Jan 30, 2015 at 2:15 PM, Konrad Windszus <[email protected]> wrote: >>>> What about adding annotations like >>>> https://code.google.com/p/jsr-305/source/browse/trunk/ri/src/main/java/javax/annotation/CheckForNull.java >>>> >>>> <https://code.google.com/p/jsr-305/source/browse/trunk/ri/src/main/java/javax/annotation/CheckForNull.java> >>>> to the Sling API? >>> >>> +1 >>> >>> I wonder if there is a static analyser which can fail the build when >>> violations are found, e.g. immediately dereferencing the result of a >>> method which is @Nullable. >>> >>> Robert >> > > > > -- > Sent from my (old) computer
