[
https://issues.apache.org/jira/browse/SLING-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318166#comment-14318166
]
Felix Meschberger commented on SLING-4372:
------------------------------------------
Looks good so far, except that I would not do the
CommonResourceResolverFactory.add method: I think it is not the task of the
ResourceResolverImpl to add itself to the references. It is the task of the
CommonResourceResovlerFactoryImpl to do this, probably in the
getResourceResolverInternal method.
> The use of finalize in ResourceResolver leads to performance issues
> -------------------------------------------------------------------
>
> Key: SLING-4372
> URL: https://issues.apache.org/jira/browse/SLING-4372
> Project: Sling
> Issue Type: Improvement
> Affects Versions: Resource Resolver 1.1.12
> Reporter: Konrad Windszus
> Assignee: Carsten Ziegeler
> Fix For: Resource Resolver 1.1.14
>
>
> Currently there is a finalizer implemented for the ResourceResolverImpl
> (http://svn.apache.org/repos/asf/sling/trunk/bundles/resourceresolver/src/main/java/org/apache/sling/resourceresolver/impl/ResourceResolverImpl.java).
> This defers garbage collection. For a more detailed analysis and also some
> metrics around that have a look at
> https://issues.apache.org/jira/browse/JCR-2768.
> A similar approach like in the patch attached to JCR-2768 should be
> implemented for the ResourceResolverImpl.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
