[ 
https://issues.apache.org/jira/browse/SLING-4512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378951#comment-14378951
 ] 

Alexander Klimetschek commented on SLING-4512:
----------------------------------------------

In parallel, I am looking at json dictionaries, see SLING-4543. The changes 
will overlap, we'll need to merge it then. If json dicts are used, we'd only 
need this traversal fix as backwards compatibility for users who have their own 
(large) dictionaries.

IMO one should use the JCR built-in TraversingItemVisitor that already does 
what the TreeTraverser does.

> Traversal Warnings in OAK while creating i18n JcrResourceBundle
> ---------------------------------------------------------------
>
>                 Key: SLING-4512
>                 URL: https://issues.apache.org/jira/browse/SLING-4512
>             Project: Sling
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Srijan Bhatnagar
>            Assignee: Amit Gupta
>         Attachments: SLING-4512.diff
>
>
> org.apache.sling.i18n.impl.JcrResourceBundle#loadFully uses an XPath query to 
> load [sling:Message] nodes under given paths. If the subtree under the path 
> is too big (>1000), we receive traversal warnings in Oak. The following 
> warning is generated if the path is /libs/wcm/core/i18n/de :
> {code}
> GET /content/geometrixx/de.html HTTP/1.1] 
> org.apache.jackrabbit.oak.spi.query.Cursors$TraversingCursor Traversed 1000 
> nodes with filter Filter(query=select [jcr:path], [jcr:score], * from 
> [sling:Message] as a where isdescendantnode(a, '/libs/wcm/core/i18n/de') /* 
> xpath: /jcr:root/libs/wcm/core/i18n/de//element(*,sling:Message) */, 
> path=/libs/wcm/core/i18n/de//*); consider creating an index or changing the 
> query
> {code}
> A suggestion would be to use 
> [TreeTraverser|http://jackrabbit.apache.org/api/2.4/org/apache/jackrabbit/commons/flat/TreeTraverser.html]
>  instead of XPath query since the subtree is mostly a flat list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to