[
https://issues.apache.org/jira/browse/SLING-6285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692831#comment-15692831
]
Julian Sedding commented on SLING-6285:
---------------------------------------
Oh, my apologies. I misread your previous comment and copy-&-pasted the long
method name. I actually was talking about
{{isAllowLoginAdministrativeForBundle}} in my previous reply.
You are correct, {{isAllowLoginAdministrativeForBundleOverridden}} checks
whether {{allowLoginAdministrativeForBundle}} is overridden. If it is
overridden, there is no need to get the {{LoginAdminWhitelist}} service,
because that's essentially an implementation detail of
{{allowLoginAdministrativeForBundle}}.
I'll add a comment as you suggest, clearly the method name was insufficcient
documentation ;) I'll also see what I can do regarding tests.
Taking up the idea from my bogus reply before: WDYT about deprecating
{{allowLoginAdministrativeForBundle}}, so we can later make it private? Then we
could simplify the logic and do away with the reflection trick.
> Implement LoginAdminWhitelist in JCR Base
> -----------------------------------------
>
> Key: SLING-6285
> URL: https://issues.apache.org/jira/browse/SLING-6285
> Project: Sling
> Issue Type: Improvement
> Components: JCR
> Affects Versions: JCR Base 2.4.2
> Reporter: Julian Sedding
> Assignee: Julian Sedding
> Fix For: JCR Oak Server 1.1.4, JCR Base 3.0.0
>
> Attachments: SLING-6285-jsedding.patch
>
>
> JCR Base should provide a default implementation
> {{AbstractSlingRepositoryManager#allowLoginAdministrativeForBundle(Bundle)}}
> with a configurable {{LoginAdminWhitelist}}. Implementation that want a
> different logic can then still choose to overwrite the method.
> cc [~cziegeler], [~bdelacretaz]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
