[ 
https://issues.apache.org/jira/browse/SLING-6785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980769#comment-15980769
 ] 

Konrad Windszus commented on SLING-6785:
----------------------------------------

While in general I think this feature is useful I have some remarks on the patch
# It is only used with {{Adaptable.adaptTo()}} but not with the 
{{ModelFactory}} approach, I think both should behave more or less the same. 
Otherwise this feature would not be available in HTL scripts due to the 
dedicated use provider added in https://issues.apache.org/jira/browse/SLING-4447
# Supporting a different scope than the lifetime of the adaptable is very 
dangerous and should therefore not be supported. Hence I would call the 
attribute rather {{cached}}.
# the javadoc of the scope/cached element in the model annotation should be 
clarified


> Add support for scoped lifecycle of sling models
> ------------------------------------------------
>
>                 Key: SLING-6785
>                 URL: https://issues.apache.org/jira/browse/SLING-6785
>             Project: Sling
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Christophe Jelger
>            Priority: Minor
>         Attachments: SLING-6785.diff
>
>
> Similar to the scopes of JEE beans 
> (http://docs.oracle.com/javaee/6/tutorial/doc/gjbbk.html), it would be nice 
> to have the possibility to set a scope for sling models.
> For example, a sling model instance could be reused for all the components 
> within the same HTTP request, thus avoiding that multiple instances of the 
> "same" model are created.
> This could be an attribute of the {{@model}} annotation, for example 
> something like:
> {{@model(scope="request")}}
> The {{request}} scope sounds straightforward for a sling model adapted from a 
> request.
> For models adapted from a resource, there are scenarios where the resource 
> itself is not relevant once the model has been instantiated, so it would 
> still be useful to be able to obtain the same model instance for different 
> components and resources within the same HTTP request.
> We could possibly have the same scopes than the JEE beans scope: {{request}}, 
> {{session}}, and {{application}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to