[ 
https://issues.apache.org/jira/browse/SLING-9577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17155346#comment-17155346
 ] 

Timothee Maret commented on SLING-9577:
---------------------------------------

You also added a bug 😥 it can be that none of the the bounded set of messages 
is consumed. I really think we should dedicate our time to look forward: make 
sure no seed is required by changing the way we consider the cache to be 
seeded. 

When it comes to the Apache rules, by this message I allow you to override my 
veto if you consider the consensus is reached and its really impossible to 
extract common code without changing the code semantic.

> Switch back to seeding thread
> -----------------------------
>
>                 Key: SLING-9577
>                 URL: https://issues.apache.org/jira/browse/SLING-9577
>             Project: Sling
>          Issue Type: Improvement
>          Components: Content Distribution
>    Affects Versions: Content Distribution Journal Core 0.1.16
>            Reporter: Christian Schneider
>            Assignee: Christian Schneider
>            Priority: Major
>             Fix For: Content Distribution Journal Core 0.1.18
>
>
> The current code uses a combination of seeding thread, persisting and loading 
> offsets from sling repo and sending single seeding messages.
> In sum this means we send at least one seeding message (seeding thread) on 
> first run and one seeding message on following runs.
> I propose to switch back to a pure seeding thread solution and make sure it 
> terminates correctly. This solution should in almost all cases also just send 
> 1 message and is a lot simpler.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to