[ 
https://issues.apache.org/jira/browse/SLING-9873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17226567#comment-17226567
 ] 

Timothee Maret commented on SLING-9873:
---------------------------------------

[~bhardwajrahul20] thanks for the patch. It makes a lot of sense to use the 
{{:}} character as separator as it's not a valid jcr character in node names. I 
have one suggestion though. The current patch is not doing a smooth migration. 
If the new code process packages with the old separator {{,}} it will block the 
queue. I think it should be possible to extend the patch slightly such that it 
supports both the {{,}} and {{:}} separators. We could figure out the package 
separator mode by looking at the first separation between {{DSTRPCK}} and the 
operation (e.g. {{DELETE}}).

> A comma in node name causes Sling Content Distribution to fail
> --------------------------------------------------------------
>
>                 Key: SLING-9873
>                 URL: https://issues.apache.org/jira/browse/SLING-9873
>             Project: Sling
>          Issue Type: Bug
>          Components: Content Distribution
>    Affects Versions: Content Distribution Core 0.4.2
>            Reporter: Rahul Bhardwaj
>            Priority: Major
>             Fix For: Content Distribution Core 0.4.4
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Sling content distribution uses comma as a path delimiter [0]but comma is a 
> valid jcr character name and hence must not be used as a path delimiter. 
> Usage of a comma in name breaks Delete operation of forward replication. 
> [0] - 
> https://github.com/apache/sling-org-apache-sling-distribution-core/blob/master/src/main/java/org/apache/sling/distribution/packaging/impl/SimpleDistributionPackage.java#L101



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to