[EMAIL PROTECTED] (Justin Mason) writes: > ah, I didn't post examples of what the new formatting looks like -- > here it is in "report_safe 1":
The example I posted *was* "report_safe 1", so the new formatting does not look like that at all. > Now, I can't find any agreement in bugzilla that those limits > should have been imposed. ;) Nice try, but today's code changes are the things that get votes, not code changes from 2 years ago... > our current translations have the following description lengths: > > German: under 50 chars: 201 too long: 380: 65% too long > French: 236 158: 40% too long > Dutch: 476 113: 19% too long > Polish: 275 107: 28% too long > > in other words *none* of our translations yet implement the 50 character > limit (bug 4007, bug 4040). In bug 4040, Klaus notes that he doubts it's > *possible* to bring German descriptions under 50 characters anyway. I'm more willing to discuss increases to description lengths (given the expansion factor of many languages over English) than rule name lengths as I think carrying over to two lines does not render reports that unreadable. However, I think increasing the rule name length from 22 is too much. If I look at all of the rule name lengths from the custom rule sets (including a French one) on the Wiki, 9992 rules have a length of 22 or lower and only 16 rules have a length of 23 or 24 (none are longer than 24). > 1. allows German-language 70-character descriptions ;) German typically requires approximately 25-35% the length of English, so changing the limit to 65 or 70 characters would be fine with me. > 2. allows long enough rule names to support the additional 13 characters > that should be added to each rule name in automc (bug ID, comment number, > "T_MC_" prefix, and underscores between them, ie. > "T_MC_rulename_2243_13"). right now, we avoid this more-or-less by just > adding 7 chars, "MC_rulename_9Ac". But still, "make test" and buildbot > will fail, if a bug with a rule name of longer than 15 characters in it is > mass-checked. Just ignore the limits for T_ rules. That's fine with me. Daniel -- Daniel Quinlan http://www.pathname.com/~quinlan/
