-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Daniel Quinlan writes:
> [EMAIL PROTECTED] writes:
>
> >> - if (eval { ("" =~ m{$re}); 1; }) {
> >> + my $evalstr = '("" =~ ' . $re . '); 1;';
> >> + if (eval $evalstr) {
> >> return 1;
> >> }
>
> [EMAIL PROTECTED] (Justin Mason) writes:
>
> > that's not going to work -- it has to be an interpolation of a var inside
> > the pattern, as in "m{$re}", otherwise perl's regexp security checks will
> > not take place -- which is half the purpose of that function. (and
> > the most important half, at that ;)
>
> Well, the problem was that $re isn't exactly how it would be later run,
> so the pattern being tested was something like:
>
> m{/foo/}
>
> We could do *both* evals. The more significant part of my fix was
> changing the head test code to strip off the "Subject =~" and
> "[if-unset: foo]" stuff.
We could do both, but is this the cause of the t/mimeheader.t
test failures? in that case, it just needs to be fixed imo.
Are there tests in the test suite for the redirector usage case btw?
- --j.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Exmh CVS
iD8DBQFCgk1JMJF5cimLx9ARAt48AKClilreDNG3dY2c8Dzhso5dj4wAPgCgiV1Z
0jRElI6ChGhPae4y3y75BdM=
=TBbB
-----END PGP SIGNATURE-----
