https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6775

             Bug #: 6775
           Summary: Curl fails on trunk for sa-update due to parameters of
                    --retry
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: PC
        OS/Version: Windows 7
            Status: NEW
          Severity: normal
          Priority: P2
         Component: sa-update
        AssignedTo: [email protected]
        ReportedBy: [email protected]
    Classification: Unclassified


I'm using curl v7.9.5 on a devel box.  As shown below, this doesn't include the
retry option. 

We need to identify a fix but my recommendation is to remove the --retry and
--retry-delay params or add a required version of curl.

Patching to remove the retry args works as expected.


I.e. this patch:

Index: sa-update.raw
===================================================================
--- sa-update.raw       (revision 1302465)
+++ sa-update.raw       (working copy)
@@ -1389,7 +1389,7 @@
   if (defined $ext_prog && $ext_prog eq 'curl') {
     push(@args, qw(-s -L -O --remote-time -g --max-redirs 2
                    --connect-timeout 15 --max-time 300
-                   --fail --retry 3 --retry-delay 20 -o), $out_fname_short);
+                   --fail -o), $out_fname_short);
     push(@args, '-z', $out_fname_short)  if $out_fname_exists &&
!$force_reload;
   } elsif (defined $ext_prog && $ext_prog eq 'wget') {
     push(@args, qw(-q -N --max-redirect=2 --tries=3 --wait=20 --random-wait


Debug output prior: 
Mar 19 10:21:47.415 [13886] dbg: logger: adding facilities: all
Mar 19 10:21:47.415 [13886] dbg: logger: logging level is DBG
Mar 19 10:21:47.415 [13886] dbg: generic: SpamAssassin version 3.4.0-r1197259
Mar 19 10:21:47.416 [13886] dbg: generic: Perl 5.008006, PREFIX=/usr/local,
DEF_RULES_DIR=/usr/local/share/spamassassin,
LOCAL_RULES_DIR=/etc/mail/spamassassin, LOCAL_STATE_DIR=/var/lib/spamassassin
Mar 19 10:21:47.416 [13886] dbg: config: timing enabled
Mar 19 10:21:47.417 [13886] dbg: config: score set 0 chosen.
Mar 19 10:21:47.425 [13886] dbg: dns: no ipv6
Mar 19 10:21:47.425 [13886] dbg: dns: is Net::DNS::Resolver available? yes
Mar 19 10:21:47.425 [13886] dbg: dns: Net::DNS version: 0.48
Mar 19 10:21:47.425 [13886] dbg: generic: sa-update version svn1208601
Mar 19 10:21:47.425 [13886] dbg: generic: using update directory:
/var/lib/spamassassin/3.004000
Mar 19 10:21:47.541 [13886] dbg: diag: perl platform: 5.008006 linux
Mar 19 10:21:47.541 [13886] dbg: diag: [...] module installed: Digest::SHA1,
version 2.01
Mar 19 10:21:47.541 [13886] dbg: diag: [...] module installed: HTML::Parser,
version 3.68
Mar 19 10:21:47.541 [13886] dbg: diag: [...] module installed: Net::DNS,
version 0.48
Mar 19 10:21:47.541 [13886] dbg: diag: [...] module installed: NetAddr::IP,
version 4.043
Mar 19 10:21:47.541 [13886] dbg: diag: [...] module installed: Time::HiRes,
version 1.65
Mar 19 10:21:47.541 [13886] dbg: diag: [...] module installed: Archive::Tar,
version 1.76
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: IO::Zlib,
version 1.04
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: Digest::SHA1,
version 2.01
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: MIME::Base64,
version 3.05
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: DB_File, version
1.810
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: Net::SMTP,
version 2.26
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module not installed: Mail::SPF
('require' failed)
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module not installed:
IP::Country::Fast ('require' failed)
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed:
Razor2::Client::Agent, version 2.84
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module not installed:
IO::Socket::INET6 ('require' failed)
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: IO::Socket::SSL,
version 0.96
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: Compress::Zlib,
version 1.33
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module not installed: Mail::DKIM
('require' failed)
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: DBI, version
1.616
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: Getopt::Long,
version 2.34
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: LWP::UserAgent,
version 2.003
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module installed: HTTP::Date,
version 1.44
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module not installed:
Encode::Detect ('require' failed)
Mar 19 10:21:47.542 [13886] dbg: diag: [...] module not installed:
Net::Patricia ('require' failed)
Mar 19 10:21:47.543 [13886] dbg: gpg: Searching for 'gpg'
Mar 19 10:21:47.544 [13886] dbg: util: current PATH is:
/usr/local/sbin:/usr/local/bin:/usr/local/bind/bin:/usr/local/bind/sbin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/java/bin:/usr/local/mysql/bin:/usr/X11R6/bin
Mar 19 10:21:47.544 [13886] dbg: util: executable for gpg was found at
/usr/local/bin/gpg
Mar 19 10:21:47.544 [13886] dbg: gpg: found /usr/local/bin/gpg
Mar 19 10:21:47.544 [13886] dbg: gpg: release trusted key id list:
5E541DC959CB8BAC7C78DFDC4056A61A5244EC45
0C2B1D7175B852C64B3CDC716C55397824F434CE
Mar 19 10:21:47.545 [13886] dbg: channel: attempting channel
updates.spamassassin.org
Mar 19 10:21:47.545 [13886] dbg: channel: using existing directory
/var/lib/spamassassin/3.004000/updates_spamassassin_org
Mar 19 10:21:47.545 [13886] dbg: channel: channel cf file
/var/lib/spamassassin/3.004000/updates_spamassassin_org.cf
Mar 19 10:21:47.545 [13886] dbg: channel: channel pre file
/var/lib/spamassassin/3.004000/updates_spamassassin_org.pre
Mar 19 10:21:47.553 [13886] dbg: dns: 0.4.3.updates.spamassassin.org =>
1293136, parsed as 1293136
Mar 19 10:21:47.553 [13886] dbg: channel: preparing temp directory for new
channel
Mar 19 10:21:47.553 [13886] dbg: channel: created tmp directory
/tmp/.spamassassin13886fxq2q2tmp
Mar 19 10:21:47.554 [13886] dbg: generic: lint checking site pre files once
before attempting channel updates
Mar 19 10:21:47.554 [13886] dbg: generic: SpamAssassin version 3.4.0-r1197259
Mar 19 10:21:47.554 [13886] dbg: generic: Perl 5.008006, PREFIX=/usr/local,
DEF_RULES_DIR=/usr/local/share/spamassassin,
LOCAL_RULES_DIR=/etc/mail/spamassassin, LOCAL_STATE_DIR=/var/lib/spamassassin
Mar 19 10:21:47.554 [13886] dbg: config: timing enabled
Mar 19 10:21:47.555 [13886] dbg: config: score set 0 chosen.
Mar 19 10:21:47.557 [13886] dbg: dns: no ipv6
Mar 19 10:21:47.557 [13886] dbg: dns: is Net::DNS::Resolver available? yes
Mar 19 10:21:47.557 [13886] dbg: dns: Net::DNS version: 0.48
Mar 19 10:21:47.557 [13886] dbg: ignore: using a test message to lint rules
Mar 19 10:21:47.557 [13886] dbg: config: using "/etc/mail/spamassassin" for
site rules pre files
Mar 19 10:21:47.558 [13886] dbg: config: read file
/etc/mail/spamassassin/init.pre
Mar 19 10:21:47.558 [13886] dbg: config: read file
/etc/mail/spamassassin/v310.pre
Mar 19 10:21:47.558 [13886] dbg: config: read file
/etc/mail/spamassassin/v312.pre
Mar 19 10:21:47.558 [13886] dbg: config: read file
/etc/mail/spamassassin/v320.pre
Mar 19 10:21:47.559 [13886] dbg: config: read file
/etc/mail/spamassassin/v330.pre
Mar 19 10:21:47.559 [13886] dbg: config: read file
/etc/mail/spamassassin/v340.pre
Mar 19 10:21:47.559 [13886] dbg: config: using
"/tmp/.spamassassin13886fxq2q2tmp/doesnotexist" for sys rules pre files
Mar 19 10:21:47.559 [13886] dbg: config: using
"/tmp/.spamassassin13886fxq2q2tmp/doesnotexist" for default rules dir
Mar 19 10:21:47.559 [13886] dbg: config: using
"/tmp/.spamassassin13886fxq2q2tmp/doesnotexist/doesnotexist" for user prefs
file
Mar 19 10:21:47.560 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::URIDNSBL from @INC
Mar 19 10:21:47.567 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::Hashcash from @INC
Mar 19 10:21:47.571 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::Pyzor from @INC
Mar 19 10:21:47.574 [13886] dbg: pyzor: local tests only, disabling Pyzor
Mar 19 10:21:47.574 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::Razor2 from @INC
Mar 19 10:21:47.577 [13886] dbg: razor2: local tests only, skipping Razor
Mar 19 10:21:47.577 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::SpamCop from @INC
Mar 19 10:21:47.582 [13886] dbg: reporter: local tests only, disabling SpamCop
Mar 19 10:21:47.582 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::AWL from @INC
Mar 19 10:21:47.588 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::AutoLearnThreshold from @INC
Mar 19 10:21:47.590 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::WhiteListSubject from @INC
Mar 19 10:21:47.592 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::MIMEHeader from @INC
Mar 19 10:21:47.593 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::ReplaceTags from @INC
Mar 19 10:21:47.596 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::DKIM from @INC
Mar 19 10:21:47.602 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::Check from @INC
Mar 19 10:21:47.611 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::HTTPSMismatch from @INC
Mar 19 10:21:47.613 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::URIDetail from @INC
Mar 19 10:21:47.615 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::Bayes from @INC
Mar 19 10:21:47.628 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::BodyEval from @INC
Mar 19 10:21:47.631 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::DNSEval from @INC
Mar 19 10:21:47.634 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::HTMLEval from @INC
Mar 19 10:21:47.637 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::HeaderEval from @INC
Mar 19 10:21:47.645 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::MIMEEval from @INC
Mar 19 10:21:47.649 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::RelayEval from @INC
Mar 19 10:21:47.652 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::URIEval from @INC
Mar 19 10:21:47.653 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::WLBLEval from @INC
Mar 19 10:21:47.657 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::VBounce from @INC
Mar 19 10:21:47.659 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::ImageInfo from @INC
Mar 19 10:21:47.662 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::FreeMail from @INC
Mar 19 10:21:47.666 [13886] dbg: plugin: loading
Mail::SpamAssassin::Plugin::AskDNS from @INC
Mar 19 10:21:47.671 [13886] dbg: config: finish parsing
Mar 19 10:21:47.671 [13886] dbg: plugin:
Mail::SpamAssassin::Plugin::ReplaceTags=HASH(0x921da08) implements
'finish_parsing_end', priority 0
Mar 19 10:21:47.671 [13886] dbg: plugin:
Mail::SpamAssassin::Plugin::FreeMail=HASH(0x9461614) implements
'finish_parsing_end', priority 0
Mar 19 10:21:47.672 [13886] dbg: replacetags: replacing tags
Mar 19 10:21:47.672 [13886] dbg: replacetags: done replacing tags
Mar 19 10:21:47.672 [13886] dbg: FreeMail: no freemail_domains entries defined,
disabling plugin
Mar 19 10:21:47.672 [13886] dbg: config: score set 0 chosen.
Mar 19 10:21:47.672 [13886] dbg: config: time limit 300.0 s
Mar 19 10:21:47.673 [13886] dbg: message: main message type: text/plain
Mar 19 10:21:47.673 [13886] dbg: message: ---- MIME PARSER START ----
Mar 19 10:21:47.673 [13886] dbg: message: parsing normal part
Mar 19 10:21:47.673 [13886] dbg: message: storing a body to memory
Mar 19 10:21:47.673 [13886] dbg: message: ---- MIME PARSER END ----
Mar 19 10:21:47.674 [13886] dbg: check: pms new, time limit in 299.999 s
Mar 19 10:21:47.674 [13886] dbg: plugin:
Mail::SpamAssassin::Plugin::DNSEval=HASH(0x9354a1c) implements 'check_start',
priority 0
Mar 19 10:21:47.675 [13886] dbg: plugin:
Mail::SpamAssassin::Plugin::Check=HASH(0x92b40e8) implements 'check_main',
priority 0
Mar 19 10:21:47.676 [13886] dbg: config: trusted_networks are not configured;
it is recommended that you configure trusted_networks manually
Mar 19 10:21:47.676 [13886] dbg: metadata: X-Spam-Relays-Trusted: 
Mar 19 10:21:47.676 [13886] dbg: metadata: X-Spam-Relays-Untrusted: 
Mar 19 10:21:47.676 [13886] dbg: metadata: X-Spam-Relays-Internal: 
Mar 19 10:21:47.676 [13886] dbg: metadata: X-Spam-Relays-External: 
Mar 19 10:21:47.677 [13886] dbg: plugin:
Mail::SpamAssassin::Plugin::AskDNS=HASH(0x9463574) implements
'extract_metadata', priority 0
Mar 19 10:21:47.677 [13886] dbg: dns: is_dns_available() last checked
1332166907.7 seconds ago; re-checking
Mar 19 10:21:47.677 [13886] dbg: dns: is DNS available? 0
Mar 19 10:21:47.677 [13886] dbg: check: tagrun - tag RELAYSTRUSTED is now
ready, value: 
Mar 19 10:21:47.677 [13886] dbg: check: tagrun - tag RELAYSUNTRUSTED is now
ready, value: 
Mar 19 10:21:47.677 [13886] dbg: check: tagrun - tag RELAYSINTERNAL is now
ready, value: 
Mar 19 10:21:47.677 [13886] dbg: check: tagrun - tag RELAYSEXTERNAL is now
ready, value: 
Mar 19 10:21:47.678 [13886] dbg: check: tagrun - tag LANGUAGES is now ready,
value: <UNDEF>
Mar 19 10:21:47.678 [13886] dbg: message: no encoding detected
Mar 19 10:21:47.678 [13886] dbg: plugin:
Mail::SpamAssassin::Plugin::URIDNSBL=HASH(0x9171a18) implements
'parsed_metadata', priority 0
Mar 19 10:21:47.678 [13886] dbg: rules: local tests only, ignoring RBL eval
Mar 19 10:21:47.679 [13886] dbg: check: check_main, time limit in 299.994 s
Mar 19 10:21:47.681 [13886] dbg: dns: harvest_dnsbl_queries
Mar 19 10:21:47.682 [13886] dbg: check: is spam? score=0 required=5
Mar 19 10:21:47.682 [13886] dbg: check: tests=
Mar 19 10:21:47.682 [13886] dbg: check: subtests=
Mar 19 10:21:47.684 [13886] dbg: timing: total 123 ms - init: 115 (93.4%),
parse: 1.29 (1.0%), extract_message_metadata: 3 (2.2%), get_uri_detail_list:
1.50 (1.2%)
Mar 19 10:21:47.684 [13886] dbg: plugin:
Mail::SpamAssassin::Plugin::MIMEHeader=HASH(0x9213b94) implements
'finish_tests', priority 0
Mar 19 10:21:47.684 [13886] dbg: plugin:
Mail::SpamAssassin::Plugin::Check=HASH(0x92b40e8) implements 'finish_tests',
priority 0
Mar 19 10:21:47.686 [13886] dbg: generic: lint check of site pre files
succeeded, continuing with channel updates
Mar 19 10:21:47.686 [13886] dbg: channel: protocol family available: inet
Mar 19 10:21:47.686 [13886] dbg: channel: MIRRORED.BY not available
Mar 19 10:21:47.708 [13886] dbg: http: url:
http://spamassassin.apache.org/updates/MIRRORED.BY
Mar 19 10:21:47.708 [13886] dbg: http: downloading to:
/var/lib/spamassassin/3.004000/updates_spamassassin_org/MIRRORED.BY, new
Mar 19 10:21:47.709 [13886] dbg: util: executable for curl was found at
/usr/bin/curl
Mar 19 10:21:47.709 [13886] dbg: http: /usr/bin/curl -s -L -O --remote-time -g
--max-redirs 2 --connect-timeout 15 --max-time 300 --fail --retry 3
--retry-delay 20 -o MIRRORED.BY --
http://spamassassin.apache.org/updates/MIRRORED.BY
curl: option --retry is unknown
curl: try 'curl --help' for more information
Mar 19 10:21:47.823 [13886] dbg: http: process [13887], exit status: 512
Mar 19 10:21:47.824 [13886] dbg: channel: no mirror data available for channel
updates.spamassassin.org from
http://spamassassin.apache.org/updates/MIRRORED.BY
error: no mirror data available for channel updates.spamassassin.org
channel: MIRRORED.BY contents were missing, channel failed
Mar 19 10:21:47.824 [13886] dbg: generic: cleaning up temporary directory/files
Mar 19 10:21:47.824 [13886] dbg: generic: cleaning directory
/tmp/.spamassassin13886fxq2q2tmp
Mar 19 10:21:47.824 [13886] dbg: diag: updates complete, exiting with code 4

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to