On Fri, Jun 24, 2011 at 12:44 AM, Rene Gielen <gie...@it-neering.net> wrote:
> Great work, Johannes!
>
> The only thing that concerns me a bit is that we seem to have lost the
> commit history of the new plugin, since you have applied the sandbox
> sources as patch to the current plugin. The history how p1 mutated to p2
> is imo important ...
Ouch. You are right, keeping the history is important. If we can go
back and address this, I would suggest that we do that.
--
Martin Cooper
> How do others feel about this? It's not too late to revert this to a move.
>
> - René
>
> On 23.06.11 23:24, Johannes Geppert wrote:
>> Hi Guys,
>>
>> I have copied the latest version of the Portlet 1.0 Plugin to the archive
>> and replaced the version in trunk with the sandbox version. Also i have made
>> same small changes on the Portlet Sample App which is running fine in
>> jetspeed for me with the new portlet plugin version.
>>
>> I have only one Problem in Test PortletRequestMapTest in Method
>> testEntrySet()
>>
>> public void testEntrySet() {
>> MockPortletRequest request = new MockPortletRequest();
>> request.setAttribute("testAttribute1", "testValue1");
>> request.setAttribute("testAttribute2", "testValue2");
>>
>> PortletRequestMap map = new PortletRequestMap(request);
>> Set entries = map.entrySet();
>>
>> //TODO Why is Entry Size 3?
>> assertEquals(2, entries.size());
>> Iterator it = entries.iterator();
>> Map.Entry entry = (Map.Entry)it.next();
>> checkEntry(entry);
>> entry = (Map.Entry)it.next();
>> checkEntry(entry);
>>
>> }
>>
>> The Test runs into Failure because the entries.size() == 3 ?!?
>> This Test runs in the Sandbox version. Has anyone an Idea or Suggestion?
>>
>> Johannes
>>
>> -----
>> web: http://www.jgeppert.com
>> twitter: http://twitter.com/jogep
>> --
>> View this message in context:
>> http://struts.1045723.n5.nabble.com/Portlet-2-0-Plugin-was-moved-to-trunk-tp4519115p4519115.html
>> Sent from the Struts - Dev mailing list archive at Nabble.com.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
>> For additional commands, e-mail: dev-h...@struts.apache.org
>>
>
> --
> René Gielen
> IT-Neering.net
> Saarstrasse 100, 52062 Aachen, Germany
> Tel: +49-(0)241-4010770
> Fax: +49-(0)241-4010771
> Cel: +49-(0)163-2844164
> http://twitter.com/rgielen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
> For additional commands, e-mail: dev-h...@struts.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
