[
https://issues.apache.org/jira/browse/SYNCOPE-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529997#comment-13529997
]
Francesco Chicchiriccò edited comment on SYNCOPE-242 at 12/12/12 2:47 PM:
--------------------------------------------------------------------------
This patch - generated from attached tgz - is working for me.
Only, after applying the patch on a fresh checkout, I had to manually remove 9
empty files:
core/src/main/java/org/apache/syncope/core/util/ConnObjectUtil.java
core/src/main/java/org/apache/syncope/core/util/PasswordGenerator.java
core/src/main/java/org/apache/syncope/core/persistence/validation/entity/SyncopeUserValidator.java
core/src/main/java/org/apache/syncope/core/sync/SyncResult.java
core/src/main/java/org/apache/syncope/core/sync/SyncActions.java
core/src/main/java/org/apache/syncope/core/init/WorkflowLoader.java
src/main/java/org/apache/syncope/core/security/PasswordEncoder.java
src/main/java/org/apache/syncope/core/propagation/PropagationActions.java
src/main/java/org/apache/syncope/core/rest/controller/InvalidSearchConditionException.java
I have generated the patch with
svn diff --show-copies-as-adds > ~/Downloads/SYNCOPE-242-fromtgz.patch
--show-copies-as-adds is supported on Subversion 1.7+ and is the only way to
generate consistent patches when moving or deleting files
was (Author: ilgrosso):
This patch - generated from attached tgz - is working for me.
I have generated it with
svn diff --show-copies-as-adds > ~/Downloads/SYNCOPE-242-fromtgz.patch
--show-copies-as-adds is supported on Subversion 1.7+ and is the only way to
generate consistent patches when moving or deleting files
> Resolve dependency cycles between persistence and the rest of syncope core
> --------------------------------------------------------------------------
>
> Key: SYNCOPE-242
> URL: https://issues.apache.org/jira/browse/SYNCOPE-242
> Project: Syncope
> Issue Type: Improvement
> Affects Versions: 1.0.3-incubating
> Reporter: Christian Schneider
> Fix For: 1.1.0
>
> Attachments: SYNCOPE-242-1.patch, SYNCOPE-242-2.patch,
> SYNCOPE-242-fromtgz.patch, syncope_core_after.png, syncope_core_before.png,
> syncope.tgz
>
>
> When analysing if we could move the persistence and persistence impl into
> separate modules I found that there are a lot of dependency cycles in the
> syncope core module. I have added a structure 101 diagram of the cycles to
> the issue so you can take a look.
> Especially the cycles between persistence and the rest of core are important
> as they prevent us from moving these packages out of core.
> I have already done some experimentations how to solve the cycles and am
> pretty sure I can fix that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
