[ 
https://issues.apache.org/jira/browse/SYNCOPE-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102943#comment-16102943
 ] 

Francesco Chicchiriccò commented on SYNCOPE-1173:
-------------------------------------------------

{quote}
Francesco, could you review my merge to master when you get a chance? Once 
you're happy I'll backmerge it. 
{quote}

LGTM, please go ahead.

{quote}
BTW does Syncope have a position on introducing Java 8 idioms to master? I used 
the streams API a bit in the tests. It's a lot cleaner but I guess I have to 
rewrite it for 2.0.x...
{quote}

I see the streams API only in 
[UserIssuesITCase|https://github.com/apache/syncope/blob/dde0773f3321a9dc5a92fd1404f273af48cfc6c9/fit/core-reference/src/test/java/org/apache/syncope/fit/core/UserIssuesITCase.java#L1353].

Anyway, we have SYNCOPE-938 exactly for this purpose: ideally, I would remove 
any usage of {{CollectionUtils}} / {{IterableUtils}} / etc which can be safely 
replaced by its Java 8 counterpart.
About this, are you aware of some Maven plugin (including PMD / Checkstyle / 
...) which can be run to highlight missing usage of Java 8 APIs? My Netbeans 
keeps suggesting that, but only when I open a given Java class where 
compatibility is set to JDK 8 (as {{master}} branch).

> Replace List<String> dynGroups with List<MembershipTO> dynMemberships
> ---------------------------------------------------------------------
>
>                 Key: SYNCOPE-1173
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-1173
>             Project: Syncope
>          Issue Type: Improvement
>            Reporter: Colm O hEigeartaigh
>            Assignee: Colm O hEigeartaigh
>             Fix For: 2.0.5, 2.1.0
>
>
> This task is to replace List<String> dynGroups with List<MembershipTO> 
> dynMemberships in UserTO and AnyObjectTO. This will allow us to retrieve the 
> dynamic group names associated with a given user or Any Object when doing a 
> GET, as opposed to the current situation where we only see the keys of the 
> group.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to