andrea-patricelli commented on a change in pull request #329:
URL: https://github.com/apache/syncope/pull/329#discussion_r831263975
##########
File path:
client/idrepo/console/src/main/java/org/apache/syncope/client/console/init/ClassPathScanImplementationLookup.java
##########
@@ -263,9 +263,10 @@ public void load() {
@SuppressWarnings("unchecked")
public <T> List<Class<? extends T>> getClasses(final Class<T> reference) {
- return classes.getOrDefault(reference.getName(), List.of()).stream().
- map(clazz -> (Class<? extends T>) clazz).
- collect(Collectors.toList());
+ return classes.entrySet().stream()
Review comment:
This code
https://github.com/apache/syncope/blob/master/client/idm/console/src/main/java/org/apache/syncope/client/console/commons/IdMImplementationInfoProvider.java#L46-L69
Searches by `PullCorrelationRuleConf`, while the
`ClassPathScanImplementationLookup` contains `DefaultPullCorrelationRuleConf`
The `getOrDefault` matches by specific class, not by superclass, like the
2_1_X does here
https://github.com/apache/syncope/blob/2_1_X/core/logic/src/main/java/org/apache/syncope/core/logic/init/ClassPathScanImplementationLookup.java#L183-L201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
