ilgrosso commented on code in PR #513:
URL: https://github.com/apache/syncope/pull/513#discussion_r1316233310
##########
client/am/console/src/main/resources/org/apache/syncope/client/console/clientapps/ClientAppDirectoryPanel.properties:
##########
@@ -66,3 +66,4 @@ compose.title=username attribute provider
usernameAttributeProviderConf.title=Username Attribute Provider for ${name}
ticketExpirationPolicy=Ticket Expiration Policy
auditHistory.title=Configuration history
+logoutType=Logout Type
Review Comment:
Please add the new key to all language files, not just default and `it`
##########
core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/ClientAppDataBinderImpl.java:
##########
@@ -343,5 +343,6 @@ protected void copyToEntity(final ClientApp clientApp,
final ClientAppTO clientA
}
clientApp.setProperties(clientAppTO.getProperties());
+ clientApp.setLogoutType(clientAppTO.getLogoutType());
Review Comment:
add the other way round to `copyToTO` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
