2017-01-06 16:57 GMT+02:00 Violeta Georgieva <miles...@gmail.com>: > > > > 2017-01-06 15:44 GMT+02:00 Violeta Georgieva <miles...@gmail.com>: > > > > > > > > 2017-01-06 15:24 GMT+02:00 Rémy Maucherat <r...@apache.org>: > > > > > > 2017-01-06 13:58 GMT+01:00 Violeta Georgieva <miles...@gmail.com>: > > > > > > > I'm observing the exception below: > > > > > > > > > > Maybe but I fail to see the actual problem in the generated code, and it's > > > not normal anyway that it makes a difference when the change is to replace > > > <bugs:Bug48616b /> with <bugs:Bug48616b></bugs:Bug48616b>. > > > However, I should have used tagHandlerVar rather than > > > n.getTagHandlerPoolName() for the boolean variable, for sure. > > > > Thanks with that change I do not see the exception anymore. > > Hm I see other issues now :( > > An error occurred at line: 8 in the jsp file: <tag-file> > <var-name> cannot be resolved to a variable > > I'll try to extract a simple test case ...
With r1775598 changes, the declaration of the scripting variable now is in try/finally block and it is not visible outside this block. http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/jasper/compiler/Generator.java?view=markup&pathrev=1775598#l2713 > > > > > > Rémy > > > > > > > > > > > [junit] An error occurred at line: 20 in the jsp file: > > > > /bug48nnn/bug48616.jsp > > > > [junit] Duplicate local variable > > > > _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused > > > > [junit] 17: <%@ taglib prefix="bugs" uri=" http://tomcat.apache.org/ > > > > bugs" > > > > %> > > > > [junit] 18: <bugs:Bug48616b /> > > > > [junit] 19: <bugs:Bug46816a> > > > > [junit] 20: <bugs:Bug48616b></bugs:Bug48616b> > > > > [junit] 21: </bugs:Bug46816a> > > > > [junit] > > > > [junit] > > > > [junit] Stacktrace:] with root cause > > > > [junit] org.apache.jasper.JasperException: Unable to compile class > > > > for > > > > JSP: > > > > [junit] > > > > [junit] An error occurred at line: 20 in the jsp file: > > > > /bug48nnn/bug48616.jsp > > > > [junit] Duplicate local variable > > > > _005fjspx_005ftagPool_005fbugs_005fBug48616b_005fnobody_reused > > > > [junit] 17: <%@ taglib prefix="bugs" uri=" http://tomcat.apache.org/ > > > > bugs" > > > > %> > > > > [junit] 18: <bugs:Bug48616b /> > > > > [junit] 19: <bugs:Bug46816a> > > > > [junit] 20: <bugs:Bug48616b></bugs:Bug48616b> > > > > [junit] 21: </bugs:Bug46816a> > > > > [junit] > > > > [junit] > > > > [junit] Stacktrace: > > > > [junit] at > > > > org.apache.jasper.compiler.DefaultErrorHandler.javacError( > > > > DefaultErrorHandler.java:103) > > > > [junit] at > > > > org.apache.jasper.compiler.ErrorDispatcher.javacError( > > > > ErrorDispatcher.java:212) > > > > [junit] at > > > > org.apache.jasper.compiler.JDTCompiler.generateClass(JDTCompiler.java:457) > > > > [junit] at > > > > org.apache.jasper.compiler.Compiler.compile(Compiler.java:377) > > > > [junit] at > > > > org.apache.jasper.compiler.Compiler.compile(Compiler.java:349) > > > > > > > > > > > > I succeeded to modify one of our tests in order to reproduce the issue. > > > > > > > > > > > > test.entry=org.apache.jasper.compiler.TestScriptingVariabler > > > > > > > > > > > > Index: bug48616.jsp > > > > =================================================================== > > > > --- bug48616.jsp (revision 1777593) > > > > +++ bug48616.jsp (working copy) > > > > @@ -17,5 +17,5 @@ > > > > <%@ taglib prefix="bugs" uri="http://tomcat.apache.org/bugs"; %> > > > > <bugs:Bug48616b /> > > > > <bugs:Bug46816a> > > > > - <bugs:Bug48616b /> > > > > + <bugs:Bug48616b></bugs:Bug48616b> > > > > </bugs:Bug46816a> > > > > \ No newline at end of file > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > > > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > >
