https://bz.apache.org/bugzilla/show_bug.cgi?id=60852
Bug ID: 60852
Summary: Connector property compressableMimeType incorrectly
spelled
Product: Tomcat 9
Version: 9.0.0.M17
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: 1983-01...@gmx.net
Target Milestone: -----
The word "compressable" does not exist according to Merriam Webster or the
Oxford Dictionary. It seems simply to be a typo:
> $ grep -ri --exclude-dir=.svn compressable .
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java: private
> String compressableMimeType =
> "text/html,text/xml,text/plain,text/css,text/javascript,application/javascript,application/json,application/xml";
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java: private
> String[] compressableMimeTypes = null;
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java: public String
> getCompressableMimeType() { return compressableMimeType; }
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java: public void
> setCompressableMimeType(String valueS) {
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
> compressableMimeType = valueS;
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
> compressableMimeTypes = null;
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java: public
> String[] getCompressableMimeTypes() {
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java: String[]
> result = compressableMimeTypes;
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
> StringTokenizer tokens = new StringTokenizer(compressableMimeType, ",");
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
> compressableMimeTypes = result;
> ./java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
> processor.setCompressableMimeTypes(getCompressableMimeTypes());
> ./java/org/apache/coyote/http11/Http11Processor.java: protected String[]
> compressableMimeTypes;
> ./java/org/apache/coyote/http11/Http11Processor.java: * @param
> compressableMimeTypes MIME types for which compression should be
> ./java/org/apache/coyote/http11/Http11Processor.java: public void
> setCompressableMimeTypes(String[] compressableMimeTypes) {
> ./java/org/apache/coyote/http11/Http11Processor.java:
> this.compressableMimeTypes = compressableMimeTypes;
> ./java/org/apache/coyote/http11/Http11Processor.java: private boolean
> isCompressable() {
> ./java/org/apache/coyote/http11/Http11Processor.java: if
> (compressableMimeTypes != null) {
> ./java/org/apache/coyote/http11/Http11Processor.java: return
> (startsWithStringArray(compressableMimeTypes,
> ./java/org/apache/coyote/http11/Http11Processor.java: boolean
> isCompressable = false;
> ./java/org/apache/coyote/http11/Http11Processor.java:
> isCompressable = isCompressable();
> ./java/org/apache/coyote/http11/Http11Processor.java: if
> (isCompressable) {
> ./java/org/apache/coyote/http11/Http11Processor.java: if
> (isCompressable) {
> ./webapps/docs/config/http.xml: <attribute name="compressableMimeType"
> required="false">
A fix is fairly easy, but would require an incompatible change. This is
possible in Tomcat 9 only. For Tomcat 8.5.x one could introduce new methods
(getter, setter) calling old ones, mark as @Deprecated and change http.xml for
the new one only. Old config should continue to run as expected.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
