On Mon, Jul 17, 2017 at 1:43 PM, Mark Thomas <ma...@apache.org> wrote:
> On 17/07/17 11:20, Rémy Maucherat wrote: > > On Mon, Jul 17, 2017 at 9:59 AM, Mark Thomas <ma...@apache.org> wrote: > > > >> Hi, > >> > >> I plan to check that the unit tests pass for the current trunks and then > >> tag these. If everything goes well, this should happen later today. > >> > > +1 > > > > Should we continue cleaning up findbugs after that ? > > I thought I had fixed all of those... > > Ah, I always run FindBugs from the IDE rather than the command line. > I've just run it from the command line. Ouch. > > Looks like the command line is configured to report Low confidence > issues and above whereas my IDE reports Medium confidence issues and > above by default. > > The first handful of issues I looked at seemed valid but of (very) low > severity so it looks like there is some work to do there :( > > I'm currently thinking that I'll look at these after tagging. Given the > number of issues, it might be a couple of releases before they are all > resolved. > I was looking at the report produced from the command line. Coty was looking at beginner stuff, so there's plenty of that here (when the issues are valid enough) :) > > On a related note, I think I've found the root cause of some of the > intermittent HTTP/2 test failures. I'm investigating a possible fix. > > Of course, there is nothing stopping anyone starting on the FindBugs > issues now if they feel the urge to scratch that itch. > > Rémy
