Thanks comments.
fixed in r1310163.

2012/4/5 Mark Thomas <ma...@apache.org>:
> On 05/04/2012 11:46, Konstantin Kolinko wrote:
>> 2012/4/5  <kfuj...@apache.org>:
>>> Author: kfujino
>>> Date: Thu Apr  5 10:08:38 2012
>>> New Revision: 1309734
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1309734&view=rev
>>> Log:
>>> Add new attributes of enabled and disabled to UserConfig.
>>
>> The name "enabled" is usually used for a boolean attribute that
>> disables a feature as a whole.
>>
>> Maybe name the new attributes as  "enabledUser" and "disabledUser" ?
>
> allow and deny would be consistent with other valves.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>



-- 
Keiichi.Fujino

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to