https://issues.apache.org/bugzilla/show_bug.cgi?id=54728

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
This has been fixed in trunk.

Your first patch isn't far off. I dropped o.a.catalina.websocket as the old
implementation needed to be dropped at some point and now was a good a time as
any.

The other differences were:
- leave init() as is
- move most of the constructor to preInit() (similar to your doAfterUpgrade())
- call preInit() from the Servlet immediately after calling
HttpServletRequest.upgrade()

The actual upgrade is performed by the container once the Servlet.service()
method exits. The upgrade() call doesn't trigger the upgrade it just tells the
container which object is to handler the connection once the current HTTP
request completes.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to