Author: markt Date: Mon May 12 15:12:46 2014 New Revision: 1593995 URL: http://svn.apache.org/r1593995 Log: Fix FindBugs false positive
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1593995&r1=1593994&r2=1593995&view=diff ============================================================================== --- tomcat/trunk/res/findbugs/filter-false-positives.xml (original) +++ tomcat/trunk/res/findbugs/filter-false-positives.xml Mon May 12 15:12:46 2014 @@ -291,6 +291,13 @@ <Bug code="Nm" /> </Match> <Match> + <!-- Increment is in sync block so it is safe. Volatile is used so reading + thread sees latest value. --> + <Class name="org.apache.tomcat.dbcp.pool2.impl.DefaultPooledObject" /> + <Method name="allocate" /> + <Bug pattern="VO_VOLATILE_INCREMENT" /> + </Match> + <Match> <!-- Return value is ignored but a null result will trigger an exception --> <Class name="org.apache.tomcat.jdbc.pool.ConnectionPool$ConnectionFuture" /> <Method name="get" /> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org