As promised a few (non-exhaustive) comments on source and POMs:
* Serializable tools don't have a serialVersionUID
* A lot of code does not use generics
* Boilerplate code which can be replaced with Commons Lang 3, e.g.,
Verify, ClassUtils, StringUtils. Engine relies on it anyway.
* There is plenty of room to improve the POMs, duplicate stuff,
inconsistent stuff, etc.
* Why is generic shading json-simple? Make this optional and everyone
using JsonTool can add it to the runtime scope. This makes it impossible
to swap it.
* Some stuff is deprecated, why hasn't it been dropped from this major
version?
I'll work on the POMs in a separate branch.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org
