[WICKET-3166] - isVisibleInHierarchy() possibly unnecessarily checks
children whose parents are invisible?
I'm +1 to revert the change at this ticket because we start to make
unnecessary visibility checks due an recursion that always stack calls to
every component parent. I know it is important to respect any parent
visibility restriction, but if the component has an restriction by itself,
than we don't need to code such parent test.



On Wed, Nov 24, 2010 at 6:25 AM, Martin Grigorov <mgrigo...@apache.org>wrote:

> On Wed, Nov 24, 2010 at 4:22 AM, Jeremy Thomerson <
> jer...@wickettraining.com
> > wrote:
>
> > This vote is to release wicket 1.4.14. This is a bugfix release on the
> > 1.4.x (stable) branch.
> >
> > Branch: http://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.14/
> > Artifacts: 
> > http://people.apache.org/~jrthomerson/wicket-1.4.14/dist<http://people.apache.org/%7Ejrthomerson/wicket-1.4.14/dist>
> > Maven repo: 
> > http://people.apache.org/~jrthomerson/wicket-1.4.14/m2-repo<http://people.apache.org/%7Ejrthomerson/wicket-1.4.14/m2-repo>
> > Changelog:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310561&styleName=Html&version=12315480
>
> The changelog is wrong.
>
> +    * [WICKET-3135] - Improve JavaScriptPackageResource#toString() to show
> filename instead of default Object#toString()
> +    * [WICKET-3136] - JVM 1.6 crash caused by WicketObjectOutputStream,
> ClassStreamHandler, and Page.writePageObject
>
> These are not resolved yet.
>
> >
> >
> > This vote ends Friday, November 26 at 10:30pm (US/EST or UTC/GMT -5
> hours)
> >
> > Please test the release and offer your vote:
> > [ ] Yes, release
> > [ ] No, don't release it (and please tell us why)
> >
> >
> > --
> > Jeremy Thomerson
> > http://wickettraining.com
> > Need a CMS for Wicket?  Use Brix! http://brixcms.org
> >
>



-- 
Pedro Henrique Oliveira dos Santos

Reply via email to