Instead of dropping it would you prefer I submit a patch that re-enables it?

-Clint

On Tue, Jun 28, 2011 at 7:36 AM, Martin Grigorov <mgrigo...@apache.org>wrote:

> Yes. This setting is ignored in current trunk.
>
> On Tue, Jun 28, 2011 at 3:10 PM, Clint Checketts <checke...@gmail.com>
> wrote:
> > We use setEnforceMounts(). Would that be broken too by this change?
> >
> > Ws Martin saying that BookmarkableMapper isn't using the setting at all
> in
> > 1.5?
> >
> > -Clint
> >
> > On Tue, Jun 28, 2011 at 4:49 AM, Martin Grigorov <mgrigo...@apache.org
> >wrote:
> >
> >> OK, I'll remove it.
> >> Seems easy enough to re-add if someone ever need it.
> >>
> >> On Mon, Jun 27, 2011 at 6:11 PM, Igor Vaynberg <igor.vaynb...@gmail.com
> >
> >> wrote:
> >> > i think we can drop this from 1.5
> >> >
> >> > -igor
> >> >
> >> > On Mon, Jun 27, 2011 at 3:14 AM, Martin Grigorov <
> mgrigo...@apache.org>
> >> wrote:
> >> >> Hi,
> >> >>
> >> >> In 1.5
> org.apache.wicket.settings.ISecuritySettings.getEnforceMounts()
> >> >> is not currently used.
> >> >> Reading its javadoc I understand that it should disable completely
> >> >> org.apache.wicket.request.mapper.BookmarkableMapper when the flag is
> >> >> "true".
> >> >> I.e. making a request to /wicket/bookmarkable/com.example.MyPage
> >> >> should not be recognized by BookmarkableMapper.
> >> >> Am I right ?
> >> >>
> >> >> --
> >> >> Martin Grigorov
> >> >> jWeekend
> >> >> Training, Consulting, Development
> >> >> http://jWeekend.com
> >> >>
> >> >
> >>
> >>
> >>
> >> --
> >> Martin Grigorov
> >> jWeekend
> >> Training, Consulting, Development
> >> http://jWeekend.com
> >>
> >
>
>
>
> --
> Martin Grigorov
> jWeekend
> Training, Consulting, Development
> http://jWeekend.com
>

Reply via email to